Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Set Outfit command/verb #29672

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Fix Set Outfit command/verb #29672

merged 5 commits into from
Sep 19, 2024

Conversation

Tayrtahn
Copy link
Member

@Tayrtahn Tayrtahn commented Jul 3, 2024

About the PR

The admin setoutfit command and verb menu option now function in a reasonable manner again.

Specifically, the list of outfits no longer includes all the little fragments of outfits that were added for loadouts, and setting one of the job "gear" outfits no longer makes the character mostly-naked.

Why / Balance

These were broken when loadouts were added to the game, and they're handy for testing and admin stuff.
Fixes #28785
Fixes #27112

Technical details

  • The list of outfits filters out any StartingGearPrototypes that are referenced by a LoadoutPrototype.
  • When applying the outfit, if it is referenced as a JobPrototype's StartingGear, that job's RoleLoadout is now looked up and applied to the character if possible. If the target character is controlled by a player, their loadout for that job will be used if they have one. If the command is targeting an Urist instead, the default (species-appropriate) loadout for that job will be used.

Media

Screenshot 2024-07-02 at 8 12 06 PM
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@github-actions github-actions bot added Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged. labels Jul 3, 2024
@ps3moira
Copy link
Contributor

ps3moira commented Jul 3, 2024

finally <3

@Verbalase Verbalase mentioned this pull request Jul 13, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 25, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
@metalgearsloth
Copy link
Contributor

Somewhat skrunkly but it's a command so doesn't need to be perfect.

@metalgearsloth
Merge remote-tracking branch 'upstream/master' into set-outfit-returns
462d3b4 
# Conflicts:
#	Content.Client/Administration/UI/SetOutfit/SetOutfitMenu.xaml.cs
@metalgearsloth
squishy
b49a397
@metalgearsloth metalgearsloth merged commit 94ad76f into space-wizards:master Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@Chief-Engineer Chief-Engineer Awaiting requested review from Chief-Engineer Chief-Engineer is a code owner

Assignees
No one assigned
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged.
Projects
NextGen WizDen Adminning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetOutfit verb/command is no longer functional Debug Set Outfit Options Changed
3 participants
@Tayrtahn @ps3moira @metalgearsloth